On Fri, 15 Sep 2023 05:36:30 GMT, Tejesh R <[email protected]> wrote: >> Open source these Swing PopupMenu related tests: >> >> javax/swing/JPopupMenu/4236750/bug4236750.java >> javax/swing/JPopupMenu/4321273/bug4321273.java >> javax/swing/JPopupMenu/4711693/bug4711693.java >> javax/swing/JPopupMenu/4962731/bug4962731.java >> javax/swing/JPopupMenu/4966109/bug4966109.java >> javax/swing/JPopupMenu/5091257/bug5091257.java > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix
Changes requested by psadhukhan (Reviewer). test/jdk/javax/swing/JPopupMenu/bug4321273.java line 45: > 43: public static JFrame frame; > 44: public static JMenu menu; > 45: public static JMenuBar menuBar; this can be local var test/jdk/javax/swing/JPopupMenu/bug5091257.java line 40: > 38: * @test > 39: * @bug 5091257 > 40: * @summary APPLICATION KEY DOES NOT DISPLAY A POP-UP MENU IN USERS VIEW Make in lower case test/jdk/javax/swing/JPopupMenu/bug5091257.java line 132: > 130: }); > 131: robot.keyPress(KeyEvent.VK_CONTEXT_MENU); > 132: robot.setAutoDelay(10); should be delay...autoDelay should be set while creating robot instance...also if you set autoDelay there's no need of additional delay between key events.. ------------- PR Review: https://git.openjdk.org/jdk/pull/15704#pullrequestreview-1632329766 PR Review Comment: https://git.openjdk.org/jdk/pull/15704#discussion_r1329509483 PR Review Comment: https://git.openjdk.org/jdk/pull/15704#discussion_r1329510865 PR Review Comment: https://git.openjdk.org/jdk/pull/15704#discussion_r1329511500
