On Mon, 18 Sep 2023 21:53:36 GMT, Harshitha Onkar <[email protected]> wrote:
>> Following tests are open sourced as part of this PR.
>>
>> 1. java/awt/event/PaintEvent/RepaintTest/RepaintTest.java
>> 2. javax/swing/text/html/HTMLEditorKit/4214848/bug4214848.java
>> 3. javax/swing/text/html/HTMLEditorKit/4230197/bug4230197.java
>> 4. javax/swing/text/html/HTMLEditorKit/4238223/bug4238223.java
>
> Harshitha Onkar has updated the pull request incrementally with one
> additional commit since the last revision:
>
> review changes
test/jdk/java/awt/event/PaintEvent/RepaintTest.java line 111:
> 109: // is incremented, this counter is displayed in the component.
> 110: private static class IncrementComponent extends Component {
> 111: private static AtomicInteger paintCount = new AtomicInteger(0);
Suggestion:
private static final AtomicInteger paintCount = new AtomicInteger(0);
It should be `final`.
test/jdk/java/awt/event/PaintEvent/RepaintTest.java line 119:
> 117: public AtomicInteger getCount() {
> 118: return paintCount;
> 119: }
This could continue to return `int`, you could hide the internals from the
`main` method.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15751#discussion_r1329884981
PR Review Comment: https://git.openjdk.org/jdk/pull/15751#discussion_r1329885827
