On Tue, 19 Sep 2023 07:46:20 GMT, Prasanta Sadhukhan <[email protected]> wrote:
>> These are the tests being converted: >> >> javax/swing/JTree/4696499/bug4696499.java >> javax/swing/JTree/5039542/bug5039542.java >> javax/swing/JViewport/4546474/bug4546474.java >> javax/swing/JViewport/4677611/bug4677611.java >> javax/swing/KeyboardManager/4345798/bug4345798.java > > test/jdk/javax/swing/KeyboardManager/bug4345798.java line 50: > >> 48: private static JFrame f; >> 49: private static JButton b; >> 50: private static JMenu menu; > > guess it can be local var JFrame needs to be disposed in the finally block. JButton is needed in the TestActionListener. And the JMenu is needed for the getLocationOnScreen call on line 84. I believe these need to be static instead of local vars. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15802#discussion_r1330419106
