On Mon, 18 Sep 2023 21:35:01 GMT, Alexander Zvegintsev <[email protected]> wrote:
> Open sourcing several MenuBar manual tests > > java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_1.java > java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_2.java > java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_3.java > java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_4.java Marked as reviewed by psadhukhan (Reviewer). test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_1.java line 29: > 27: import java.awt.MenuBar; > 28: import java.awt.event.MouseAdapter; > 29: import java.awt.event.MouseEvent; seems consistency suggests to put awt imports before swing..applicable for all tests test/jdk/java/awt/MenuBar/AddRemoveMenuBarTests/AddRemoveMenuBarTest_4.java line 59: > 57: > 58: After a menubar has been replaced with another menubar, > 59: the frame should not be resized nor repositioned on the > screen. Can we not automate it? I mean we can do the click by robot and then check frame.getSize and getLocationOnScreen before and after click, no? Probably applicable for all tests which tests "frame should not be resized nor repositioned on the screen" ------------- PR Review: https://git.openjdk.org/jdk/pull/15800#pullrequestreview-1634633829 PR Review Comment: https://git.openjdk.org/jdk/pull/15800#discussion_r1330994831 PR Review Comment: https://git.openjdk.org/jdk/pull/15800#discussion_r1330998459
