On Mon, 2 Oct 2023 23:56:12 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Remove pack for explicit size > > test/jdk/java/awt/dnd/RejectDragDropActionTest.java line 90: > >> 88: Robot robot = new Robot(); >> 89: robot.waitForIdle(); >> 90: robot.delay(DELAY_TIME); > > Does adding `robot.autoWaitForIdle(true)` additionally increase the stability > of the test since it has subsequent DnD events performed by the robot? Sure, I just added it. Previously when I initially worked on this test, setAutoWaitForIdle had a weird interaction with how the test was setup. Since the test used a delay of 50ms between each of the movements when dragging the selection, it caused long delays. Looks like this is resolved now, and the method doesn't add any unreasonable delays anymore. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16018#discussion_r1344515836
