> Refactored timeout handling in PassFailJFrame: > > 1. Managing the timer and formatting the time left is inside `TimeoutHandler` > class. > 2. The class handles timer events and updates the label accordingly. > > This is implemented on top of #15665.
Alexey Ivanov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 16 commits: - Merge master - Refactor failure reason Ensure the failure reason doesn't change after it's set. Removed 'failed' and 'timeout' fields: if failureReason is set, the test fails. - 8316017: Refactor timeout handler in PassFailJFrame - Remove trailing whitespace - Mark the Builder class final It's not supposed to be extended. - Amend message in window closing handler The WindowClosingHandler is used both for the instruction frame and for test UI windows. Also add blank lines to separate different parts of the class. - Use invokeOnEDT in getInstructionFrameBounds - Use functional style for disposing of windows Also clean up the doc for disposeWindows(). - Use statically imported invokeAndWait and isEDT - Build functional test UI The Builder now provides a method to create test UI, PassFailJFrame automatically invokes the method reference on the EDT and then shows both the instruction frame and the test window. - ... and 6 more: https://git.openjdk.org/jdk/compare/c587211b...f590891b ------------- Changes: https://git.openjdk.org/jdk/pull/15668/files Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=15668&range=02 Stats: 149 lines in 1 file changed: 92 ins; 33 del; 24 mod Patch: https://git.openjdk.org/jdk/pull/15668.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/15668/head:pull/15668 PR: https://git.openjdk.org/jdk/pull/15668
