On Tue, 31 Oct 2023 08:06:25 GMT, Matthias Baesken <mbaes...@openjdk.org> wrote:
>> src/java.desktop/unix/native/libawt_xawt/xawt/XlibWrapper.c line 2303:
>>
>>> 2301: if (!pRect) {
>>> 2302: (*env)->ReleaseIntArrayElements(env, bitmap, values,
>>> JNI_ABORT);
>>> 2303: JNU_ThrowOutOfMemoryError(env, "malloc failed");
>>
>> I think the throw is unnecessary. You will get some incorrect rendering, but
>> that's all.
>
> So should I remove the JNU_ThrowOutOfMemoryError ? The calloc in the same
> file has a JNU_ThrowOutOfMemoryError (but maybe the situation is different
> there?) .
Fair question. That other case is used only during initialisation and if they
fail then some things are not set up properly.
So different enough. Yes, I think you can remove the one you are adding. If it
ever happens it could be recoverable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16392#discussion_r1377841716
