On Thu, 2 Nov 2023 11:07:27 GMT, Julian Waters <[email protected]> wrote:
>> We should set the -permissive- flag for the Microsoft Visual C compiler, as >> was requested by the now backed out >> [JDK-8241499](https://bugs.openjdk.org/browse/JDK-8241499). Doing so makes >> the Visual C compiler much less accepting of ill formed code, which will >> improve code quality on Windows in the future. > > Julian Waters has updated the pull request incrementally with one additional > commit since the last revision: > > Changes awt_Frame.cpp src/java.desktop/windows/native/libawt/windows/awt_Canvas.cpp line 218: > 216: > 217: AwtCanvas *c; > 218: c = (AwtCanvas*) pData; you probably explained it in some other thread, perhaps in an earlier review but what exactly is the problem with the existing code ? The new code looks like something that begs to be undone. src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 61: > 59: > 60: jfieldID AwtPrintDialog::pageID; > 61: where and why did this come from ? src/java.desktop/windows/native/libawt/windows/awt_PrintJob.cpp line 533: > 531: > 532: { > 533: HWND parentID = AwtPrintControl::getParentID(env, self); diff is making this really hard to compare line by line So here you've just put the code in { .. } and indented ? What is the warning that motivates this ? I don't see where you describe it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1380641669 PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1380780091 PR Review Comment: https://git.openjdk.org/jdk/pull/15096#discussion_r1380781297
