On Wed, 8 Nov 2023 08:54:17 GMT, Tejesh R <[email protected]> wrote:
>> `BackingStore` uses its own Graphics to Paint the Image. This is fine when
>> we want to paint it on a Window/Frame, but fails to print. Since
>> `WPathGraphics` is used for Printing, backing store fails to print it and
>> backing store uses newly created `SunGraphics2D` always. The proposed fix is
>> to ignore `backingstore` graphics if passed on Graphics is different from
>> `SunGraphics2D` which ensures the Image is painted on Window and also
>> printed when required.
>> The fix is tested in CI and doesn't cause any regression. The test is
>> verified manually.
>
> Tejesh R has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review fix
test/jdk/javax/swing/JTable/JTableScrollPrintTest.java line 198:
> 196: }
> 197:
> 198: protected void processWindowEvent(WindowEvent e) {
I guess this is not required
Also, please confirm JTable is getting printed correctly either from existing
testcases in javax/swing/JTable and from SwingSet2..
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1386272073
