On Thu, 9 Nov 2023 15:33:57 GMT, Alexey Ivanov <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix for custom renderer
>
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxButton.java line
> 201:
>
>> 199: }
>> 200:
>> 201: final Component getRendererComponent() {
>
> Suggestion:
>
> private Component getRendererComponent() {
>
>
> I wanted to use this method in `AquaComboBoxUI` but eventually I added
> `updateAccessibleName` instead, thus this method can be made `private`.
Updated.
> src/java.desktop/macosx/classes/com/apple/laf/AquaComboBoxUI.java line 143:
>
>> 141: public void itemStateChanged(final ItemEvent e) {
>> 142:
>> 143: if (e.getStateChange() != ItemEvent.SELECTED) return;
>
> Suggestion:
>
> public void itemStateChanged(final ItemEvent e) {
> if (e.getStateChange() != ItemEvent.SELECTED) return;
>
> The blank line at the start of the method isn't necessary, is it?
Removed.
> test/jdk/javax/accessibility/JComboBox/TestJComboBoxScreenMagnifier.java line
> 81:
>
>> 79: PassFailJFrame.positionTestWindow(frame,
>> 80: PassFailJFrame.Position.HORIZONTAL);
>> 81: frame.setLocationRelativeTo(null);
>
> Suggestion:
>
>
> It's not needed, the location of the frame is set explicitly by the above
> call to `PassFailJFrame.positionTestWindow`.
Updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1388437524
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1388438449
PR Review Comment: https://git.openjdk.org/jdk/pull/14497#discussion_r1388439180
