On Fri, 10 Nov 2023 07:20:29 GMT, Tejesh R <[email protected]> wrote: >> `BackingStore` uses its own Graphics to Paint the Image. This is fine when >> we want to paint it on a Window/Frame, but fails to print. Since >> `WPathGraphics` is used for Printing, backing store fails to print it and >> backing store uses newly created `SunGraphics2D` always. The proposed fix is >> to ignore `backingstore` graphics if passed on Graphics is different from >> `SunGraphics2D` which ensures the Image is painted on Window and also >> printed when required. >> The fix is tested in CI and doesn't cause any regression. The test is >> verified manually. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Review fix
src/java.desktop/share/classes/javax/swing/JViewport.java line 52: > 50: import sun.swing.SwingUtilities2; > 51: import java.awt.PrintGraphics; > 52: import java.awt.print.PrinterGraphics; Guess these are not required.. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16552#discussion_r1389016671
