On Tue, 21 Nov 2023 19:30:58 GMT, Alexey Ivanov <[email protected]> wrote:
>> Abhishek Kumar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Remove line break > > test/jdk/javax/swing/JProgressBar/TestProgressBarBorder.java line 28: > >> 26: import java.lang.reflect.InvocationTargetException; >> 27: import java.awt.Graphics; >> 28: import java.awt.image.BufferedImage; > > IDEA at my end disagrees with the current sorting order: > Suggestion: > > import java.awt.Graphics; > import java.awt.image.BufferedImage; > import java.io.File; > import java.io.IOException; I know that the sorting order is not correct but I received a comment on my other PR https://github.com/openjdk/jdk/pull/16674#discussion_r1394632505 which suggests `it is long standing convention that the "core" packages (easily distinguished these days as those in the java.base module) are listed before the desktop / AWT / Swing ones.` That's the reason I didn't sorted the imports. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/16467#discussion_r1401458695
