On Thu, 16 Nov 2023 18:24:07 GMT, Alexey Ivanov <[email protected]> wrote:

>> Alisen Chung has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   updated test to provide information on which key was pressed
>
> test/jdk/java/awt/event/KeyEvent/AcceleratorTest/AcceleratorTest.java line 1:
> 
>> 1: /*
> 
> Is it possible to print which particular event fired? It could be useful for 
> debugging.
> 
> I'd create a list of `Action`s with the names and shortcuts (as a KeyStroke 
> and as string for printing) and then print each action name with 
> corresponding shortcut. Or create a list of objects with corresponding data. 
> I didn't think it through.

@aivanov-jdk please review

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/16664#discussion_r1409704513

Reply via email to