On Wed, 6 Dec 2023 18:04:59 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> Anton Bobrov has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 8321176: remove RuntimeException and address review comments > > Looks good to me. > >> can you please file a bug based on my description above ? > > Filed the [JDK-8321475](https://bugs.openjdk.org/browse/JDK-8321475) for this > >> and also something i thought i should mention wrt doCleanup() function. it >> might be a good idea to protect it with a mutex or something. it does look >> safe ATM but i haven't looked at related libpipewire internals to assert >> that with full certainty. there perhaps could be a situation where >> doCleanup() is called internally but also from java cleanup thread (the one >> that sleeps for 2 seconds) and if they interleave/race it might cause >> unexpected behavior or crash in libpipewire as its rather sensible in terms >> of teardown sequence (i've seen its crashing due to that in my testing and >> thats why i have reshuffled some related calls in this patch). anyways, this >> is something to look into and check. > > Sure, we should revisit it later. @azvegint super, thanks again! ------------- PR Comment: https://git.openjdk.org/jdk/pull/16978#issuecomment-1843513018
