On Thu, 7 Dec 2023 22:57:52 GMT, Sergey Bylokhov <s...@openjdk.org> wrote:
>> The fix for a regression caused by the >> https://bugs.openjdk.org/browse/JDK-6508941. it does not take into account >> RPC_E_CHANGED_MODE when COM was already initialized using >> COINIT_MULTITHREADED mode. >> >> @aivanov-jdk please take a look. > > Sergey Bylokhov has updated the pull request incrementally with three > additional commits since the last revision: > > - 8270269: Desktop.browse method fails if earlier CoInitialize call as > COINIT_MULTITHREADED > - Revert "6508941: java.awt.Desktop.open causes VM to crash with video files > sporadically" > > This reverts commit 85269470 > - Revert "8270269: Desktop.browse method fails if earlier CoInitialize call > as COINIT_MULTITHREADED" > > This reverts commit 4908d9c220950683d3a5010d12ab756eff6b6fa7. Please, update the copyright year in `WDesktopPeer.java`. src/java.desktop/windows/native/libawt/windows/awt_Desktop.cpp line 2: > 1: /* > 2: * Copyright (c) 2005, 2020, Oracle and/or its affiliates. All rights > reserved. Suggestion: * Copyright (c) 2005, 2023, Oracle and/or its affiliates. All rights reserved. ------------- Marked as reviewed by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/17010#pullrequestreview-1772707943 PR Review Comment: https://git.openjdk.org/jdk/pull/17010#discussion_r1420705243
