On Thu, 11 Jan 2024 07:07:10 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Abhishek Kumar has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Review comment fix and move file outside folder
>
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
> 161:
>
>> 159:
>> 160: expandedIconWrapper = new IconWrapper(expandedIcon);
>> 161: collapsedIconWrapper = new IconWrapper(collapsedIcon);
>
> It seems `updateStyle` is called for all `propertyChange` event so it can
> cause memory leak by doing the class instantiation every time it is called..
> Probably better place to instantiate this objects is in `installDefaults`
> after calling `updateStyle`
Updated.
> src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTreeUI.java line
> 809:
>
>> 807: }
>> 808: else {
>> 809: SynthGraphicsUtils.paintIcon(iconType, context, g, x,
>> y, w, h);
>
> Guess it can be further optimized in all these methods
>
> if (context == null) {
> context = getContext(tree);
> }
> SynthGraphicsUtils.paintIcon(iconType, context, g, x, y, w, h);
Updated
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17294#discussion_r1449015436
PR Review Comment: https://git.openjdk.org/jdk/pull/17294#discussion_r1449015571
