> When running with fastdebug binaries we run intermittent into the issue below > in > jtreg test > java/awt/image/MultiResolutionImage/MultiResolutionImageObserverTest.java . > Seems we miss checking of successful HBITMAP creation before calling > GetDIBits. > > HDC hBMDC = this->GetDC(); > HBITMAP hBM = ::CreateCompatibleBitmap(hBMDC, 1, 1); > VERIFY(::GetDIBits(hBMDC, hBM, 0, 1, NULL, gpBitmapInfo, DIB_RGB_COLORS)); > > in awt_Win32GraphicsDevice.cpp . Thats why the releast of hBMDC / hBM fails > as well at the end of the function causing the seond and third warning. > > > Sat Nov 18 17:29:23 CET 2023 > > ********************* > AWT Assertion Failure > ********************* > ::GetDIBits(hBMDC, hBM, 0, 1, 0, gpBitmapInfo, 0) > File > 'e:\openjdk\openjdk-21u-windows_x86_64-dbg\jdk\src\java.desktop\windows\native\libawt\windows\awt_Win32GraphicsDevice.cpp', > at line 184 > GetLastError() is 57 : The parameter is incorrect. > > Do you want to break into the debugger? > ********************* > ********************* > AWT Assertion Failure > ********************* > ::DeleteObject(hBM) > File > 'e:\openjdk\openjdk-21u-windows_x86_64-dbg\jdk\src\java.desktop\windows\native\libawt\windows\awt_Win32GraphicsDevice.cpp', > at line 297 > GetLastError() is 57 : The parameter is incorrect. > > So it seems, we should have some additional checks/tracing.
Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision: do not call CreateCompatibleBitmap if hBMDC is NULL, do not call GetDIBits if hBM is NULL ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17197/files - new: https://git.openjdk.org/jdk/pull/17197/files/2e0d83f1..f7a5b7e7 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17197&range=02 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17197&range=01-02 Stats: 10 lines in 1 file changed: 4 ins; 0 del; 6 mod Patch: https://git.openjdk.org/jdk/pull/17197.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17197/head:pull/17197 PR: https://git.openjdk.org/jdk/pull/17197
