On Fri, 12 Jan 2024 05:12:40 GMT, Tejesh R <t...@openjdk.org> wrote:

>> The issue is that the doc area (in respect to the screen height which is 
>> 768px) which is at the bottom was causing the `JFileChooser `to be placed 
>> slightly above the set location. Was able to reproduce in local machine with 
>> reference to the failure image provided in the CI logs. The suggested fix is 
>> to place the main Frame slightly above the center of the screen than setting 
>> at the center of the screen. Several CI runs were made and no issue found.
>
> Tejesh R has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   Review fix

test/jdk/javax/swing/JFileChooser/JFileChooserSetLocationTest.java line 216:

> 214: 
> 215:         int width = (int) screenSize.getWidth() / 2;
> 216:         int height = (int) screenSize.getHeight() / 2;

This is not the width and height, this is the kind of point(x,y) where the 
frame will be located.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/17364#discussion_r1451242135

Reply via email to