On Tue, 19 Dec 2023 02:09:08 GMT, songpv-imt <d...@openjdk.org> wrote:
>> The root cause of the bug is because mousePress() method is invoked before >> mouseMove() event is completely processed causing the drag & drop behavior >> not being able to be recognized properly. This in turn makes the method >> dragSourceListener.isDropFinished() returns false and fail the test. To fix >> this, setAutoWaitForIdle(true) and Thread.Sleep is called to make sure the >> mouseMove() event is processed completely before moving to execute the >> mousePress() method. >> >> JBS issue: [JDK-8317287](https://bugs.openjdk.org/browse/JDK-8317287) > > songpv-imt has updated the pull request incrementally with one additional > commit since the last revision: > > Update InterJVMGetDropSuccessTest.java > - Update success1 and success2 to volatile Please update the copyright year in both files to 2024. test/jdk/java/awt/dnd/InterJVMGetDropSuccessTest/InterJVMGetDropSuccessTest.java line 301: > 299: for (Point p = new Point(sourcePoint); > !p.equals(targetPoint); > 300: p.translate(Util.sign(targetPoint.x - p.x), > 301: Util.sign(targetPoint.y - p.y))) { Suggestion: p.translate(Util.sign(targetPoint.x - p.x), Util.sign(targetPoint.y - p.y))) { Align the second parameter on the wrapped line to the first one on the first line. ------------- Changes requested by aivanov (Reviewer). PR Review: https://git.openjdk.org/jdk/pull/16396#pullrequestreview-1822259995 PR Review Comment: https://git.openjdk.org/jdk/pull/16396#discussion_r1452746985
