On Tue, 30 Jan 2024 09:35:55 GMT, Tejesh R <t...@openjdk.org> wrote: >> The issue is w.r.t to way that Synth prints the table. In Synth, the >> printing of Table happens column wise by painting blocks of columns which is >> due to the fact that Graphics used which is `ProxyGrpahics2D` (which get >> selected in `RasterPrinterJob `class, otherwise it would be `WPathGraphics` >> for other Look and feel). Since the printing happens in block wise and the >> columns where the x position is greater than the `table.bounds` doesn't gets >> painted because of the intersection check condition >> `!bounds.intersects(clip)`. Hence only droplines are painted instead of >> cells and gridlines. I couldn't find any reason for adding the intersection >> check here and when removed it didn't cause any regression too, rather it >> solves the issue and actually made sense too. In other Look and Feel its not >> required to apply the fix (in `BasicTableUI `class) because its not >> affecting anything yet since the painting happens for whole table. Hence >> proposing the fix for only SynthTableUI class. >> ([PrintManualTest_FitWidthMultiple.java](https://github.com/openjdk/jdk/blob/master/test/jdk/javax/swing/JTable/PrintManualTest_FitWidthMultiple.java)) >> test is been used for testing. > > Tejesh R has updated the pull request incrementally with one additional > commit since the last revision: > > Test file updated
test/jdk/javax/swing/JTable/PrintManualTest_FitWidthMultiple.java line 29: > 27: * @summary Verify if printed content is within border and all columns > are > 28: * printed for PrintMode.FIT_WIDTH > 29: * @run main/othervm/manual > -Dswing.defaultlaf=javax.swing.plaf.nimbus.NimbusLookAndFeel > PrintManualTest_FitWidthMultiple You need to keep both not only Nimbus ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17053#discussion_r1470912862
