On Tue, 30 Jan 2024 07:02:36 GMT, Renjith Kannath Pariyangad
<rkannathp...@openjdk.org> wrote:
>> Hi Reviewers,
>>
>> Updated manual printer test cases with 'PassFailJFrame', also removed unused
>> variables. Added 'SkippedException' in case of printer missing or not
>> configured.
>>
>> Please review and let me know your suggestions.
>>
>> Regards,
>> Renjith
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Capitalized static final variables
test/jdk/java/awt/print/PrinterJob/DrawImage.java line 83:
> 81:
> 82: BufferedImageOp scaleOp = new RescaleOp(scaleFactor, 0, null);
> 83: g2D.drawImage(image, scaleOp, x + _objectBorder, y +
> _objectBorder);
dispose g2D object
test/jdk/java/awt/print/PrinterJob/InvalidPage.java line 106:
> 104: (int) pageFormat.getImageableWidth(),
> 105: (int) pageFormat.getImageableHeight());
> 106: g2d.drawLine((int) pageFormat.getImageableWidth(), 0,
dispose g2D object
test/jdk/java/awt/print/PrinterJob/JobName/PrinterJobName.java line 76:
> 74: Graphics2D g2d = (Graphics2D) g;
> 75: g2d.translate(pgFmt.getImageableX(), pgFmt.getImageableY());
> 76: g2d.drawString("Name is: " + theName, 20, 20);
dispose g2D object
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1473655667
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1473656040
PR Review Comment: https://git.openjdk.org/jdk/pull/17608#discussion_r1473656127
