On Wed, 31 Jan 2024 11:03:41 GMT, vtstydev <d...@openjdk.org> wrote: > > Also, is there any need of drawing the inner rectangle if there will not be > > any differences to it...it will be less confusing for the tester > > I need to draw something with opacity and something with transparency colors, > otherwise I couldn't compare different ways for page printing. Honestly I > don't know how to replace it with something invisible for tester except to > reduce its size
If it is only meant for you to compare like an "unit test", then you can pass an argument to the test like "java AlphaPrintingOffset testAlpha" and if "testAlpha" argument is set, then only invoke drawSmallRectangle...For other tester, the smaller rectangles are no different between fixed version and non-fixed version so of no use, I guess Also, ideally pg 1,2,3,5 are also not needed as they are same before fix and after fix and since we have to use physical printer to print and compare, 8 pages are wasted per testing iteration, when just comparing 2 pages pg 4,6 are enough for this "regression test" to prove this fix ------------- PR Comment: https://git.openjdk.org/jdk/pull/17030#issuecomment-1920510837
