> This fixes building with GCC 14: > * Cherry-pick a fix from Harfbuzz upstream > * Apply other `-Wcalloc-transposed-args` fixes to the JDK sources > > -Wcalloc-transposed-args errors out with GCC 14 as the OpenJDK build uses > -Werror. > > The calloc prototype is: > > void *calloc(size_t nmemb, size_t size); > > > So, just swap the number of members and size arguments to match the > prototype, as > we're initialising 1 struct of size `sizeof(struct ...)`. GCC then sees we're > not > doing anything wrong.
Sam James has updated the pull request incrementally with three additional commits since the last revision: - fix whitespace - Revert "harfbuzz: Cherry-pick upstream fix for GCC 14" This reverts commit acdd606c5d818baa783c6529ea58e66a061ec64a. - Conditionally pass -Wno-transposed-calloc-args for bundled harfbuzz ------------- Changes: - all: https://git.openjdk.org/jdk/pull/17506/files - new: https://git.openjdk.org/jdk/pull/17506/files/cb5b9dfc..ef698d82 Webrevs: - full: https://webrevs.openjdk.org/?repo=jdk&pr=17506&range=01 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17506&range=00-01 Stats: 5 lines in 3 files changed: 2 ins; 0 del; 3 mod Patch: https://git.openjdk.org/jdk/pull/17506.diff Fetch: git fetch https://git.openjdk.org/jdk.git pull/17506/head:pull/17506 PR: https://git.openjdk.org/jdk/pull/17506
