On Fri, 9 Feb 2024 13:12:10 GMT, Abhishek Kumar <[email protected]> wrote:
>> JTabbedPane's content area, tab area and tab background color are not as
>> expected when opaque is set to true or false.
>> The proposed fix is to handle the TabbedPane's background color in installed
>> LAFs. Manual test is added to support the fix and there is no regression
>> caused by the fix.
>>
>> Proposed fix is tested in Ubuntu 22.04 and Oracle linux.
>>
>> CI link is posted in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> spacing fix
src/java.desktop/share/classes/javax/swing/plaf/synth/SynthTabbedPaneUI.java
line 677:
> 675: }
> 676:
> 677: private Color getUnselectedBackgroundAt(int index) {
I guess `getUnselectedBackground` would be right naming convention.
test/jdk/javax/swing/JTabbedPane/TestJTabbedPaneOpaqueColor.java line 55:
> 53: private static JTabbedPane tabPane;
> 54: private static final String INSTRUCTIONS =
> 55: " In WindowsLookAndFeel, click Pass as test is not " +
Better to avoid running the test in Windows L&F.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1490561514
PR Review Comment: https://git.openjdk.org/jdk/pull/17720#discussion_r1490563245
