On Fri, 16 Feb 2024 21:30:21 GMT, Alisen Chung <[email protected]> wrote:
>> Root cause of the test failure was fixed with >> https://bugs.openjdk.org/browse/JDK-8316931, updating this test since the >> other fix also included a test update. > > Alisen Chung has updated the pull request incrementally with one additional > commit since the last revision: > > remove unused var Test LGTM now but I left some comments on minor issues. test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 45: > 43: * @run main/manual DisposeInActionEventTest > 44: */ > 45: public class DisposeInActionEventTest { Add newline between these test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 51: > 49: String instructions; > 50: if (!SystemTray.isSupported()) { > 51: throw new jtreg.SkippedException("The test cannot be run > because SystemTray is not supported."); Suggestion: throw new jtreg.SkippedException("The test cannot be run because " + "SystemTray is not supported."); test/jdk/java/awt/TrayIcon/DisposeInActionEventTest/DisposeInActionEventTest.java line 64: > 62: " (also called Taskbar Status Area on MS > Windows, Notification\n" + > 63: " Area on Gnome or System Tray on KDE) is > visible.\n" + > 64: "Double-click with " + clickInstruction + " > button on the tray icon to trigger the\n" + The instructions say to double click, but a single click right click is sufficient in macOS. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/17838#pullrequestreview-1886128600 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1493022325 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1493025074 PR Review Comment: https://git.openjdk.org/jdk/pull/17838#discussion_r1493025951
