On Mon, 19 Feb 2024 13:04:47 GMT, Matthias Baesken <[email protected]> wrote:
> In AccessBridgeJavaEntryPoints.cpp we have a couple of exception checks with
> potential early returns. Those miss ReleaseStringChars .
btw there might be further room for improvement / simplification. The current
macro code blocks look like this
EXCEPTION_CHECK_WITH_RELEASE("message1", FALSE, js, stringBytes);
EXCEPTION_CHECK("message2 for ReleaseStringChars()", FALSE);
The second parameter could be omitted because it is always FALSE anyway in
those EXCEPTION_CHECK_WITH_RELEASE blocks.
The second line EXCEPTION_CHECK could be moved into the macro
EXCEPTION_CHECK_WITH_RELEASE itself .
-------------
PR Comment: https://git.openjdk.org/jdk/pull/17915#issuecomment-1952418438
