> XToolkit implements `toFront()` essentially by sending the  
> `_NET_ACTIVE_WINDOW` message to activate the window. This has no effect when 
> the target window is in the iconified state. So the fix is to cancel that 
> state prior to sending the message.
> 
> The test verifies that the fix works for maximized and undecorated frames as 
> well out of abundance of caution; they do not represent a special case from 
> the `toFront()` standpoint.
> 
> References
> * `_NET_ACTIVE_WINDOW`: 
> https://specifications.freedesktop.org/wm-spec/1.3/ar01s03.html
> * [Inter-Client Communication Conventions Manual, 4.1.4. Changing Window 
> State](https://tronche.com/gui/x/icccm/sec-4.html#s-4.1.4)

Maxim Kartashev has updated the pull request incrementally with one additional 
commit since the last revision:

  Extended the test to all platforms and made it headful

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/17985/files
  - new: https://git.openjdk.org/jdk/pull/17985/files/429333a5..1b69d068

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=17985&range=00-01

  Stats: 3 lines in 1 file changed: 2 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/17985.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/17985/head:pull/17985

PR: https://git.openjdk.org/jdk/pull/17985

Reply via email to