On Tue, 27 Feb 2024 11:14:02 GMT, Alexey Ivanov <[email protected]> wrote:

> The root cause has been resolved under another bug. Here, you update the 
> test… because it uses `Applet`. You don't actually fix the test to make it 
> pass.
> 
> Perhaps even, create a _new bug_ with clear description and close 
> [JDK-8325097](https://bugs.openjdk.org/browse/JDK-8325097) as duplicate of 
> [JDK-8316931](https://bugs.openjdk.org/browse/JDK-8316931) because 
> JDK-8316931 fixed both failures. For this reason, JDK-8316931 deserves being 
> in the `@bug` tag in both tests: `DisposeInActionEventTest` and 
> `ShowAfterDisposeTest`.

Please, close this bug, 
[JDK-8325097](https://bugs.openjdk.org/browse/JDK-8325097), as duplicate of 
[JDK-8316931](https://bugs.openjdk.org/browse/JDK-8316931).

Create a new bug for updating the test with a clear subject. Then update the 
subject of this PR with the new bugid and summary.

Otherwise, as things stand now, you're creating _false_ records in JBS. The 
subject of this PR targeted for JDK-8325097 states *the 
`DisposeInActionEventTest.html` fails*. Then the PR resolves the failure. But 
the test **does _not_ fail** after JDK-8316931 is fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/17838#issuecomment-1969145842

Reply via email to