On Tue, 5 Mar 2024 05:28:01 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> JLabel text is not painted with the LAF defined foreground color in GTK LAF.
>> In GTK LAF the foreground color is retrieved by using native system APIs.
>> Fix is to return the foreground color if it is set by LAF defined property
>> otherwise return the default color by calling native APIs.
>> Applet based test has been converted to automatic test and check for all
>> installed LAFs. CI testing is green for test suite and individual test. Link
>> attached in JBS.
>
> Abhishek Kumar has updated the pull request incrementally with one additional
> commit since the last revision:
>
> separate method to get LAF defined color
Changes requested by psadhukhan (Reviewer).
src/java.desktop/share/classes/com/sun/java/swing/plaf/gtk/GTKStyle.java line
205:
> 203: private Color getLAFDefinedColor(SynthContext context, int state,
> 204: ColorType type, String
> propertyName) {
> 205: Color c = (Color) get(context, propertyName);
I guess these condition checks should also be done inside the method since you
are passing the values anyway...
Also, the enabled state are still not handled..If the existing testcase does
not catch those, maybe we can add subtests to it..
test/jdk/javax/swing/plaf/basic/BasicHTML/bug4248210.java line 40:
> 38: /*
> 39: * @test
> 40: * @bug 4248210 8075917 4314194
4314194 remove from here..
-------------
PR Review: https://git.openjdk.org/jdk/pull/17763#pullrequestreview-1916196212
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512316161
PR Review Comment: https://git.openjdk.org/jdk/pull/17763#discussion_r1512318090
