On Wed, 6 Mar 2024 08:31:34 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Christoph Langer has updated the pull request with a new target base due to >> a merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains 14 additional >> commits since the last revision: >> >> - declare variable hasDisplays final >> - Merge branch 'master' into JDK-8185862 >> - load awt.dll before display check >> - Change implementation of headless determination on Windows >> - Merge branch 'master' into JDK-8185862 >> - Reflect display detection in java.awt.GraphicsEnvironment::isHeadless() >> - Merge branch 'master' into JDK-8185862 >> - Get rid of global variables and restore old handling wrt calling >> ::GetDIBits >> - Merge branch 'master' into JDK-8185862 >> - Little cleanup >> - ... and 4 more: https://git.openjdk.org/jdk/compare/dcf260b9...002fba2d > > src/java.desktop/windows/classes/sun/awt/PlatformGraphicsInfo.java line 69: > >> 67: public static boolean getDefaultHeadlessProperty() { >> 68: // If we don't find usable displays, we run headless. >> 69: return !hasDisplays(); > > I wonder if redirection via a private method makes any meaningful difference > compared to returning the value of the `hasDisplays` flag directly? Good point. Fixed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17614#discussion_r1516489040
