On Mon, 11 Mar 2024 13:43:56 GMT, Alexey Ivanov <[email protected]> wrote:
>> Tejesh R has updated the pull request incrementally with three additional
>> commits since the last revision:
>>
>> - Review updates
>> - Review updates
>> - Updates
>
> test/jdk/javax/swing/border/Test4129681.java line 67:
>
>> 65: }
>> 66:
>> 67: public static void init() {
>
> I propose using `testUI` method of the builder, it hides the complexity of
> registering and positioning the frame. Modify this method to return the
> created `frame`.
>
> See PR #17838 as an example or other PRs. The javadoc for `PassFailJFrame`
> also contains the recommended usage.
If the test UI is simple enough, you can even use `splitUI` to display the test
UI along with the instructions. In this case, instead of frame return a
`JComponent`, likely `JPanel`, which contains all the test UI.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18189#discussion_r1519853979
