On Tue, 12 Mar 2024 02:47:25 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Conversion of manual applet test to main based using PassFailJFrame manual
>> framework
>
> Prasanta Sadhukhan has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Review comment update
> - Review comment update
Marked as reviewed by aivanov (Reviewer).
test/jdk/javax/swing/JFileChooser/FileFilterDescription/FileFilterDescription.java
line 54:
> 52: .rows(10)
> 53: .columns(35)
> 54: .build();
Suggestion:
.position(PassFailJFrame.Position.TOP_LEFT_CORNER)
.build();
To move the instruction frame into its final position right away since
`build()` shows the instruction UI. Later the instruction frame is moved when
you use `PassFailJFrame.positionTestWindow`.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18182#pullrequestreview-1930616215
PR Review Comment: https://git.openjdk.org/jdk/pull/18182#discussion_r1521190975
