On Tue, 12 Mar 2024 12:50:16 GMT, Alexey Ivanov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - 8327856 >> - 8327856 > > test/jdk/java/awt/InputMethods/SpanishDiacriticsTest.java line 89: > >> 87: frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE); >> 88: frame.pack(); >> 89: frame.setVisible(true); > > Suggestion: > > frame.pack(); > > Calling `setVisible(true)` here causes flickering as the frame gets shown at > its default location and later gets moved to its final location. > > Setting close operation is redundant, `PassFailJFrame` handles closing test > UI (when you use the builder pattern) and fails the test if it's closed. Calling `setVisible(true)` does not affect functionality, purely aesthetic effect to avoid window flickering. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18208#discussion_r1521899607
