On Tue, 12 Mar 2024 12:49:06 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
> Conversion of manual applet test to main based using PassFailJFrame manual
> framework
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 81:
> 79:
> 80: public static JFrame createAndShowUI() {
> 81: frame = new JFrame("Test window");
Frame title can be more descriptive.
test/jdk/javax/swing/JToggleButton/4128979/bug4128979.java line 123:
> 121: frame.setSize(600, 250);
> 122: frame.setDefaultCloseOperation(WindowConstants.EXIT_ON_CLOSE);
> 123: frame.setVisible(true);
frame.setVisible(true); redundant can be removed.
-------------
PR Review: https://git.openjdk.org/jdk/pull/18233#pullrequestreview-1933003573
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1522343889
PR Review Comment: https://git.openjdk.org/jdk/pull/18233#discussion_r1522343535
