On Tue, 12 Mar 2024 20:47:47 GMT, Phil Race <p...@openjdk.org> wrote:
>> Tejesh R has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Review updates > > test/jdk/javax/swing/border/Test4247606.java line 74: > >> 72: >> 73: Box main = Box.createVerticalBox(); >> 74: main.setBorder(BorderFactory.createEmptyBorder(8, 8, 8, 8)); > > The above empty border was not in the original test. Why is it needed ? And > why the Box too ? > Surely we should just return the value of the call to create(..) ? Yes, we can return the JPanel directly instead of Box. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18213#discussion_r1522517361
