On Tue, 12 Mar 2024 20:09:35 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> This was recently converted from a manual Applet to a PassFailJFrame main >> program >> But I see a few things that could be tweaked >> - Clarify instructions >> - Set path to PassFailJFrame >> - reduce timeout to default >> - eliminate redundant folder > > test/jdk/java/awt/TrayIcon/DisposeInActionEventTest.java line 58: > >> 56: } >> 57: String clickInstruction = >> 58: (Platform.isOSX()) ? "Right-click" : "Double click (left >> mouse button)"; > > On Linux, it triggers with a single click(Tested on Ubuntu 23.10) Manual tests that require a tester's interpretation and that are specific to the way a platform expects user interaction can be subjective but the idea is that they are objective. I already didn't like the clickInstruction logic, now I like it even less. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18246#discussion_r1522547494
