On Tue, 12 Mar 2024 18:20:14 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
> The following InputMethod test, bug8154816.java is converted to main using
> PassFailJFrame.
>
> - test renamed to PinyinIMCapsTest
> - moved one directory above - /java/awt/im/
> - html file deleted.
>
> PS: I tried to automate this test using Robot, but was unable to produce the
> same effect as a keyboard keypress for Pinyin, hence keep it as a manual test.
test/jdk/java/awt/im/PinyinIMCapsTest.java line 43:
> 41:
> 42: public class PinyinIMCapsTest {
> 43: private static final String INSTRUCTIONS = """
Can move `INSTRUCTIONS ` to main.
test/jdk/java/awt/im/PinyinIMCapsTest.java line 44:
> 42: public class PinyinIMCapsTest {
> 43: private static final String INSTRUCTIONS = """
> 44: This test is for OS X only. It verifies if the Caps Lock key
> works properly
I guess its not required to mention regarding OS X requirement in test
instructions, anyhow its taken care in jtreg tag and also a check has been made
before test initialization.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1522864097
PR Review Comment: https://git.openjdk.org/jdk/pull/18245#discussion_r1522868354
