On Wed, 13 Mar 2024 13:39:08 GMT, Abhishek Kumar <[email protected]> wrote:
> Conversion of manual applet test to automated test. CI testing is green. Link
> attached to JBS.
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JTable/bug4222153.java line 57:
> 55:
> UIManager.setLookAndFeel("javax.swing.plaf.metal.MetalLookAndFeel");
> 56: Robot robot = new Robot();
> 57: robot.setAutoDelay(100);
Delay can be reduced to 50ms
test/jdk/javax/swing/JTable/bug4222153.java line 91:
> 89: robot.keyRelease(KeyEvent.VK_TAB);
> 90: robot.delay(100);
> 91: robot.waitForIdle();
Since autodelay is already set you can remove the additional delay after key
release or reduce it to a smaller number.
Suggestion:
robot.waitForIdle();
robot.delay(20);
test/jdk/javax/swing/JTable/bug4222153.java line 95:
> 93: robot.keyRelease(KeyEvent.VK_TAB);
> 94: robot.delay(100);
> 95: robot.waitForIdle();
Same here and usually it is waitForIdle() followed by delay().
-------------
PR Review: https://git.openjdk.org/jdk/pull/18275#pullrequestreview-1934739075
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523624229
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523626805
PR Review Comment: https://git.openjdk.org/jdk/pull/18275#discussion_r1523628934
