On Wed, 13 Mar 2024 00:27:32 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Convert java/awt/im/JTextFieldTest.java applet test to main using >> PassFailJFrame. > > Damon Nguyen has updated the pull request incrementally with one additional > commit since the last revision: > > Fix suggested redudant changes test/jdk/java/awt/im/JTextFieldTest.java line 47: > 45: """ > 46: Please run this test case under Solaris cjk locale with > inputmethod > 47: support, if you could input Chinese/Japanese/Korean in the > swing The scenario here should not be specific to Solaris. I think you should rephrase the first sentence to "Please run this test in a CJK (Chinese/Japanese/Korean) locale with input method support". I some times wonder how well these tests that say "please change your environment" actually get properly tested. It is perhaps possible to do change desktop locale support on the fly but by the time you read the instructions the test is already running. That introduces another wrinkle. Maybe you need to restart at least this test. And I am not 100% sure that jtreg passes through locale vars. I hope it does. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18247#discussion_r1523718224
