On Wed, 13 Mar 2024 13:37:32 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:
>> Conversion of manual applet test to automated test. CI testing is green. >> Link attached to JBS. > > Abhishek Kumar has updated the pull request incrementally with one additional > commit since the last revision: > > Remove commented code Changes requested by honkar (Reviewer). test/jdk/javax/swing/JTable/TAB.java line 56: > 54: */ > 55: > 56: public class TAB Class name is in all-caps, `Tab` would be more appropriate. test/jdk/javax/swing/JTable/TAB.java line 88: > 86: robot.mousePress(InputEvent.BUTTON1_DOWN_MASK); > 87: robot.mouseRelease(InputEvent.BUTTON1_DOWN_MASK); > 88: robot.delay(100); Like the previous test since autoDelay() is set, this delay can be reduced or removed completely. test/jdk/javax/swing/JTable/TAB.java line 120: > 118: } > 119: > 120: static void createAndShowUI() There are few places where boxing (Integer(), Boolean()) is not required and can be removed as part of clean up. ------------- PR Review: https://git.openjdk.org/jdk/pull/18274#pullrequestreview-1935462874 PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524079096 PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524077589 PR Review Comment: https://git.openjdk.org/jdk/pull/18274#discussion_r1524076867