On Wed, 13 Mar 2024 16:56:39 GMT, Alexander Zvegintsev <azveg...@openjdk.org> wrote:
>> @azvegint, yes, we can support both. But I didn't test it thoroughly, so I >> decided it was safer to add this. >> >> Please, don't modify `PassFailJFrame` together with tests unless it's >> strictly required… It is for the sake of facilitating backporting the >> changes. Otherwise, backporting improvements to the framework will depend on >> the presence of a test. >> >> In this case, it could be fine though… provided that the test you're >> updating exists in all the repos. >> >> Either way, I think it's good to create a separate bug for `PassFailJFrame` >> which you'll resolve with the current one. > > That's a good point, I created #18281 for that. It's integrated now. Likely, you want to merge master into your branch to avoid possible conflicts, although bot don't complain about any conflict. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18250#discussion_r1524883723
