On Tue, 5 Mar 2024 11:04:30 GMT, Alexey Ivanov <[email protected]> wrote:
>> src/java.desktop/share/classes/javax/swing/plaf/basic/BasicDirectoryModel.java
>> line 101:
>>
>>> 99: */
>>> 100: public synchronized void invalidateFileCache() {
>>> 101: if (filesLoader != null) {
>>
>> This is a public API method, can we minimize the change and use
>> "synchronized (this)" instead?
>
> The `synchronized` modifier is not part of public API specification, it's not
> shown in the generated Javadoc. Anyway, I updated the code to use
> `synchronized (this)` block inside the method.
I thought that is checked by the sigtests. at least previously the removing of
synchronized keyword requires the CSR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18111#discussion_r1525408186
