On Thu, 14 Mar 2024 23:02:58 GMT, Alisen Chung <ach...@openjdk.org> wrote:
> Removing applet usage from manual JColorChooser tests
Changes requested by honkar (Reviewer).
test/jdk/javax/swing/JColorChooser/Test4887836.java line 2:
> 1: /*
> 2: * Copyright (c) 2003, 2008, 2024 Oracle and/or its affiliates. All rights
> reserved.
Same here. Please remove 2008 and add comma.
test/jdk/javax/swing/JColorChooser/Test4887836.java line 34:
> 32: * @library /java/awt/regtesthelpers
> 33: * @build PassFailJFrame
> 34: * @summary Checks if no tooltip modification when no KeyStroke modifier
@alisenchung summary doesn't match with the test.
test/jdk/javax/swing/JColorChooser/Test4887836.java line 41:
> 39: public static void main(String[] args) throws Exception {
> 40: String instructions = "If you do not see white area under the
> \"Swatches\" tab,\n" +
> 41: "then test passed, otherwise it failed.";
The original instructions seem a bit vague and the test window has a lot going
on so probably more details here would add clarity.
test/jdk/javax/swing/JColorChooser/Test4887836.java line 49:
> 47: .columns(40)
> 48: .testTimeOut(10)
> 49: .splitUIRight(Test4887836::createColorChooser)
Here having separate windows for instructions and test window look better.
Suggestion:
.testUI(Test4887836::createColorChooser)
-------------
PR Review: https://git.openjdk.org/jdk/pull/18316#pullrequestreview-1937931742
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525629485
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525633461
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525632027
PR Review Comment: https://git.openjdk.org/jdk/pull/18316#discussion_r1525632789
