On Mon, 18 Mar 2024 09:32:37 GMT, Abhishek Kumar <abhis...@openjdk.org> wrote:

>>> Is the test exclusive for Metal Look And Feel or should it be checked in 
>>> other LAFs as well? I think it may not work for Nimbus of GTK LAF as 
>>> setting the property 
>>> `UIManager.getDefaults().put("Label.disabledForeground", 
>>> labelDisableColor);` may not work.
>> 
>> Yeah, because its difficult to verify it automatically for all L&F. And yeah 
>> you are right, it didn't work for Nimbus either.
>
>> Yeah, because its difficult to verify it automatically for all L&F.
> 
> Not really, this can be done. But if it is not required to check except Metal 
> then it is ok.

I meant the label position might vary slightly for different L&F, here I have 
hardcoded it for metal L&F...... Not sure it would remain same for all the 
L&F......

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18336#discussion_r1528187092

Reply via email to