On Mon, 18 Mar 2024 06:04:49 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> test/jdk/ProblemList.txt line 788: >> >>> 786: java/awt/xembed/server/TestXEmbedServerJava.java 8001150,8004031 >>> generic-all >>> 787: java/awt/Modal/PrintDialogsTest/PrintDialogsTest.java 8068378 >>> generic-all >>> 788: java/awt/dnd/DnDFileGroupDescriptor/DnDFileGroupDescriptor.java >>> 8080185 macosx-all,linux-all >> >> @prsadhuk While looking into the test history I noticed you had previous >> worked on it PR https://github.com/openjdk/jdk/pull/3406, it wasn't >> integrated though. Any thoughts whether to make this test windows-only or >> extend the test to other platforms ? >> >> Your previous PR description sounds correct, when I went through the related >> test bugs it seemed like the test was created for windows-only issue. > > The reason it was not integrated was because of this > [comment](https://github.com/openjdk/jdk/pull/3406#pullrequestreview-632106612) > wherein it was mentioned to update the test to run without MSOutlook > dependancy so that it could be run on all platforms so making it not platform > dependant.. @prsadhuk Since the test still retains the MS Outlook requirement in instructions, should we make the test windows-only then ? Because having a combination of `@requires (os.family == "windows")` and problem-listing on macOS and linux seems contradicting. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18335#discussion_r1529005890
