On Mon, 18 Mar 2024 06:40:36 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Convert java/awt/image/MemoryLeakTest/MemoryLeakTest.java applet test to
>> main using PassFailJFrame
>
> Damon Nguyen has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Remove unneeded Global var. Review comments
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 42:
> 40: // static boolean testPassed = false;
> 41: // static Thread mainThread = null;
> 42: //}
Shouldn't this be removed?
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 74:
> 72: if (mainThread != null) {
> 73: mainThread.interrupt();
> 74: }
It is still unclear why we still need this. It seems to be a remnant of the old
TestDialog machinery.
test/jdk/java/awt/image/MemoryLeakTest/MemoryLeakTest.java line 122:
> 120:
> 121: public void componentShown(ComponentEvent e)
> 122: {
Suggestion:
public void componentShown(ComponentEvent e) {
for the consistency with other code
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529039239
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529038235
PR Review Comment: https://git.openjdk.org/jdk/pull/18307#discussion_r1529044141
