On Tue, 19 Mar 2024 18:26:34 GMT, Damon Nguyen <dngu...@openjdk.org> wrote:
>> Convert java/awt/print/Dialog/PrintApplet.java applet test to main using >> PassFailJFrame. Also rename the test to PrintModalDialog.java since this is >> no longer an applet. Added test instructions related to the linked JBS issue. > > Damon Nguyen has updated the pull request incrementally with two additional > commits since the last revision: > > - Remove unused frame > - splitUI addition. Add forceFail test/jdk/java/awt/print/Dialog/PrintModalDialog.java line 57: > 55: Finish printing or close the dialog. If both dialogs are > modal, > 56: PASS the test. Otherwise, FAIL. > 57: """; I think we need more instructions - explaining Modal and what to expect. "Modal in this case means that it blocks the user from interacting with other windows in the same application You may still be able to interact with unrelated applications on the desktop. One sure way to test this is to first show the print dialog and then press "Fail", because if you can click on "Fail" and have it respond, then the print dialog was not modal. If clicking on it does nothing then cancel the print dialog and do the same for the other print dialog. If all is well, then press Pass." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18362#discussion_r1531231867
