On Wed, 20 Mar 2024 17:27:44 GMT, Phil Race <[email protected]> wrote:
>> This seems to have been some previous not very complete conversion of a test
>> from applet to main.
>> It even still had Applet imported and miscellaneous comments. I've cleaned
>> it up.
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8328560
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
line 45:
> 43:
> 44: public class ClickDuringKeypress implements MouseListener {
> 45: //Declare things used in the test, like buttons and labels here
Comments can be removed.
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
line 67:
> 65: doTest();
> 66: } finally {
> 67: if (frame != null) {
null check should be done on EDT ?
test/jdk/java/awt/event/MouseEvent/ClickDuringKeypress/ClickDuringKeypress.java
line 88:
> 86: robot.delay(1000);
> 87: if (!ready) {
> 88: System.out.println("Not Activated. Test fails");
Looks redundant.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532530344
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532531591
PR Review Comment: https://git.openjdk.org/jdk/pull/18386#discussion_r1532533350
