Re: RFR: 8328402: Implement pausing functionality for the PassFailJFrame [v2]

[Alexey Ivanov]

On Thu, 21 Mar 2024 11:48:28 GMT, Alexander Zvegintsev <azveg...@openjdk.org> 
wrote:

>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 662:
>> 
>>> 660:             button = new 
>>> JButton(TimeoutHandlerPanel.PAUSE_BUTTON_LABEL);
>>> 661: 
>>> 662:             button.setFocusPainted(false);
>> 
>> I wonder if it's the default focus owner? Should we request focus to `Pass` 
>> instead?
>
>> I wonder if it's the default focus owner? 
> 
> It is(e.g. with `setFocusPainted(true)`):
> ![image](https://github.com/openjdk/jdk/assets/77687766/b47e9011-c47d-437d-b9b0-0e4ac88a5c6f)
> 
>> Should we request focus to Pass instead?
> 
> Probably not, to avoid accidentally passing the test, while hitting the pause 
> is harmless.

Not so sure… Pause is not the main control. I guess the focus was in the 
instructions previously, we could preserve it. It may be not worth it though.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/18368#discussion_r1533756608