On Thu, 21 Mar 2024 11:37:01 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Few closed manual applet JViewport tests are converted to main based and
>> opensourced
>
> Prasanta Sadhukhan has updated the pull request incrementally with one
> additional commit since the last revision:
>
> formatting
test/jdk/javax/swing/JViewport/bug4137282.java line 86:
> 84: }
> 85:
> 86: static void setPaneSize(int w, int h) {
Do we even need this method? It is used twice and if we just do setSize and
setPreferredSize in these two places we could drop this method and make panel
variable local. That will make it more compact and in my opinion more readable.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18418#discussion_r1534053126
